[theme] - [linkbar/metadata handling]

[kunzite1]

to make sure that these work, make sure that the function that prints entries calls Entry::print_linkbar() and Entry::print_metadata(). also make sure that Entry::print_comment(Comment c) calls Comment::print_linkbar().

Comments

[kunzite1]

it works great in bloggish because that's what i used to create it. ;)

and thanks!

[av8rmike]

In re-working the print_metadata() function for Expressive, I think I found a bug. Maybe it's different in Bloggish, I don't know. Anyway, if not all of the $.metadata fields are filled, the last known value repeats until the foreach loop is finished. In my version, I fixed it with:
if($val != "") {
# build meta row
$meta = """$meta_label_open$label$meta_label_close$meta_val_open$val$meta_val_close""";
} else {
# don't add row if there's missing meta
$meta = "";
}I guess you could fix it some other way, like adding the long string directly to $currents and not using the $meta variable at all.

[kunzite1]

i think that was a redundant check from stale code.
removed the check.

[ex_uniquewo]

Unless I'm mistaken, tags are not printed when they're the only metadata present in the entry.

[ex_uniquewo]

I think it's because of:
if ($have_meta) { }

Since size($.metadata) = 0 when you've got tags only and since tags are not printed if $have_meta == "", you're fucked.

[kunzite1]

you are correct. o.0

i'll have to fix that! XD

[scotchsour]

I think this is great but I am driving myself mad trying to figure out where is my mood icon? I had it on the left with carriep63's version but I can't figure it out in yours...

[kunzite1]

you know what? that's a good question.

i almost never use or pay attention to mood icons. this code in fact does not account for such an object...

oops. will have to fix later. in a couple days, if i remember, i'll get that done.

[scotchsour]

Thank you, I'm glad I said something then. :)

Another question about the link bar section. When you go leave a comment (i guess the comment page) I can't figure out which part of the code to remove to get rid of the text links if I have the picture version all ready there.

[scotchsour]

When you have time could you tell me how to add the number back to the comments so I don't just see a picture or need to pass over to see if somebody answered.