S2 nattering

May 19, 2006 21:54


Some comments on modifications to my journal style, for my own reference mostly.

S2 style stuff, three times fast )

lj

Leave a comment

Comments 11

jimtbari May 20 2006, 06:04:44 UTC

To keep voice posts from messing things up, you probably want to change:

## print the entry body, replacing line breaks with paragraph tags so they can be indented

var string replaced_text = replace_text ($e.text,"

","

");

"""

$replaced_text
""";

To:

## print the entry body, if possible replacing line breaks with paragraph tags so they can be indented

"""

""";
if ($e.text_must_print_trusted) {
$e->print_text();
}
else {
var string replaced_text = replace_text ($e.text,"

","

");
print $replaced_text
}
"""
""";

.

Hmm, #comments...another comment for that (if I get to it; my laptop has 15 minutes left and since my wife is using me as a pillow I can't easily charge it...)

Reply

jimtbari May 20 2006, 06:08:53 UTC
Oh, and the same thing in EntryPage::print_comment (though you don't need an if there).

And I've been given the ten minute warning, and it's two o'clock anyway. So that's all for tonight.

Reply

kate_nepveu May 20 2006, 11:40:43 UTC
What else does this affect? Because I don't surf with plugins on (Opera lets me change that very quickly, and so this keeps me from seeing a lot of ads and other annoyances), so the voice post thing doesn't affect me.

Thanks.

Reply

jimtbari May 20 2006, 15:02:53 UTC
Nothing else that I know of, though in theory they could add more later. If it's not affecting you (I had thought it was before your browser got to it), then don't worry about it. If it does, you know where to find the fix.

Reply


ckd May 20 2006, 20:37:07 UTC
Here's what I did to get the read-comments link to go to #comments (and then made it pointless by changing off the old style comment pages, and haven't fixed my entry pages yet, sigh...cobbler's kids).

function CommentInfo::print_readlink {
var Page p = get_page();
" "+
get_plural_phrase($.count, $p.view == "friends" ?
"text_read_comments_friends" : "text_read_comments")+
"
";
}

Reply

kate_nepveu May 20 2006, 23:32:32 UTC
Okay, sorry for two comments in a row where pre failed to work. Screw posting code snippets.

Anyway, I'm using function CommentInfo::print to print two things in a row, so that the comment links are in the same list, and I'm not sure how to incorporate this without breaking the layout, so I'll wait and see if there are other options.

Reply

ckd May 21 2006, 00:18:39 UTC
You should be able to just paste the function I'm using into the layout right before your CommentInfo::print.

Basically, CommentInfo::print calls the print_postlink and print_readlink functions; postlink isn't changed at all, and readlink just returns a slightly modified href.

Reply

kate_nepveu May 21 2006, 00:24:44 UTC
Well, so I can. Whaddya know.

Thanks--cargo-culting it has clear limits, obviously, and I appreciate the explanation.

Reply


Leave a comment

Up