Patch-tastic
I made patches!
The first took me ages. I grabbed it ages ago and it took me AGES to find where the relevant bit of code was, though the fix itself took me 30 seconds. Then I couldn't test it because my hack didn't have any of the customise styles bits that I needed to use; which made me wonder if I'd also edited the wrong file because a lot of the style stuff was missing from my hack. Then life got Busy and I didn't have time to figure it out. But finally last night I logged into my hack and sorted it out, with help from the very lovely people in IRC. I managed to test it by making the same change to a theme layer in actual journal and so I made the patch and uploaded it. This morning, the very lovely people in IRC explained how I can get all the styles stuff in my hack so now my hack works properly too.
The second bug I fixed was one that I had noticed while tinkering with the core2 code. It was another really easy fix that took me far longer than it should have done because some previous tinkering I'd done had broken the code and also I had failed to appreciate a) how styles in the hack work and b) how I sync the two versions of the code, but I got there eventually, with much help from
afuna who is awesome!
The third bug I did all by myself! I didn't need to ask anyone for help, I just got on with it. AND it was less trivial than the others I did. The others were literally add a simple line of code, or, in one case, add 7 characters to the code. But this one was a little more complicated. I'm so proud of myself, you would not believe!
I also started working on another bug this morning but it turns out that I can't test that one either because the search function is broken in the hacks, and I need the search function to test my fix. So that one's half done and sitting on the back burner for now.
This open source stuff is fun! \o/
---
[dw-free] "parent" class in core2 CSS causes CSS cleaner to choke
2009-06-28 | bugzilla | changelog
[dw-free] Day view page date/title has no class
2009-06-28 | bugzilla | changelog
[dw-free] Core 2: comment and entry links need class on first item
2009-06-28 | bugzilla | changelog
---
I have a bunch of invites left if anyone's interested, see DW/ LJ.
The first took me ages. I grabbed it ages ago and it took me AGES to find where the relevant bit of code was, though the fix itself took me 30 seconds. Then I couldn't test it because my hack didn't have any of the customise styles bits that I needed to use; which made me wonder if I'd also edited the wrong file because a lot of the style stuff was missing from my hack. Then life got Busy and I didn't have time to figure it out. But finally last night I logged into my hack and sorted it out, with help from the very lovely people in IRC. I managed to test it by making the same change to a theme layer in actual journal and so I made the patch and uploaded it. This morning, the very lovely people in IRC explained how I can get all the styles stuff in my hack so now my hack works properly too.
The second bug I fixed was one that I had noticed while tinkering with the core2 code. It was another really easy fix that took me far longer than it should have done because some previous tinkering I'd done had broken the code and also I had failed to appreciate a) how styles in the hack work and b) how I sync the two versions of the code, but I got there eventually, with much help from
afuna who is awesome!
The third bug I did all by myself! I didn't need to ask anyone for help, I just got on with it. AND it was less trivial than the others I did. The others were literally add a simple line of code, or, in one case, add 7 characters to the code. But this one was a little more complicated. I'm so proud of myself, you would not believe!
I also started working on another bug this morning but it turns out that I can't test that one either because the search function is broken in the hacks, and I need the search function to test my fix. So that one's half done and sitting on the back burner for now.
This open source stuff is fun! \o/
---
[dw-free] "parent" class in core2 CSS causes CSS cleaner to choke
2009-06-28 | bugzilla | changelog
[dw-free] Day view page date/title has no class
2009-06-28 | bugzilla | changelog
[dw-free] Core 2: comment and entry links need class on first item
2009-06-28 | bugzilla | changelog
---
I have a bunch of invites left if anyone's interested, see DW/ LJ.