Evolutionary Biology and Neurodiversity
Honestly, I'd love to believe that ADHD made me somehow a 'superior being', but I do think that's rather wishful thinking.
I mean, if you look at what it actually does, almost all the things are no sort of positive at all. A very few silver linings are akin to 'just' the result of training on 'hard mode' rather than actual advantages.
But what of evolutionary advantage? Well... kinda.
The problem is, natural selection/survival of the fittest isn't really about anything more complicated than 'probability of passing on genes'. So a lot of selected traits are maladaptive.
And I think that any evolutionary edge of ADHD is similarly the result of maladaptive traits too.
A simple example of a maladaptive trait is self medicating with alcohol. Short term solution, but with long term disadvantage. Such a trait may not be evolutionary disadvantageous though, if you successfully procreate first.
Indeed, if you're prone to 'getting drunk' then ... well, you're a little more likely to procreate for various 'not exactly nice' reasons.
And sadly I think the same is true of ADHD.
It demonstrably increases the rates of risk taking, sexual promiscuity, and abusive behaviors. (both victim and perpetrator sadly, due to a bunch of different trauma responses and other maladaptive traits).
As a result - and especially in 'modern society', where being 'a bit strange' isn't actually going to remove you from the genepool early - I think any sort of 'evolutionary advantage' is more down to ... well, a bunch of ugly and unfortunate maladaptions, that lead to higher procreation rates, and worse overall life outcomes at the same time.
And I think the same can be said of ASD too, for ... mostly similar reasons.
The simply truth is that 'optimal' from an evolutionary biology perspective, is distasteful and unpleasant from a civilised society perspective. And vulnerable people with mental health complications are the victims of that.