There's maybe a language barrier involved, but I didn't spot any gender assumptions in there. The choosing of if statements over switch or associative array still made me smile though.
THAT SAID, I think that this idea is neat enough not to care about implementation details like that. I believe in the good intent of the post author, and I wouldn't want him/her to be disappointed by picking in comments like this.
A friend kindly let me host it on hers, I'll agree my execution may not be the most elegant, but it spooks people who visit my lj well enough, so I'm happy :)
Actually I disagree. I could sight read it, and I don't do php. It's commented enough to grok the ideas of the routine, and it's instantly sight readable. Two very key features in good code. Means that later maintenance is easy and achievable, and that's something that you learn from experience is a really really really good thing :) Smart's no good if you can't understand it in 6 mths time.
Indeed, good documentation is vital for later code maintenance. The amount of times recently I've had bugs for areas and found the code to just be unreadable is ridiculous.
Generally I work with Java, not PHP hence my PHP isn't the best, it's more a hobby than a job :)
Reply
Reply
THAT SAID, I think that this idea is neat enough not to care about implementation details like that. I believe in the good intent of the post author, and I wouldn't want him/her to be disappointed by picking in comments like this.
Reply
Reply
Reply
And more importantly, it's currently running my lj's layout. :)
Reply
Reply
Reply
Reply
Generally I work with Java, not PHP hence my PHP isn't the best, it's more a hobby than a job :)
Reply
Leave a comment